Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipld): undeprecate for_each methods for hamt/kamt #2080

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Stebalien
Copy link
Member

These are useful because they handle some error cases and the ranged version is especially useful as using iter + skip etc. is actually kind of annoying. It would still be better to replace these with iterators in many cases, but replacing them everywhere is annoying and not worth the effort.

These are useful because they handle some error cases and the ranged
version is especially useful as using iter + skip etc. is actually kind
of annoying. It would still be better to replace these with iterators in
many cases, but replacing them _everywhere_ is annoying and not worth
the effort.
@Stebalien
Copy link
Member Author

The downside of keeping these functions is that we won't be able to remove the anyhow errors.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (d76ae62) to head (a548be6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2080      +/-   ##
==========================================
- Coverage   75.73%   75.72%   -0.01%     
==========================================
  Files         154      154              
  Lines       15691    15689       -2     
==========================================
- Hits        11883    11881       -2     
  Misses       3808     3808              
Files with missing lines Coverage Δ
ipld/amt/src/amt.rs 83.39% <ø> (ø)
ipld/amt/src/iter.rs 95.80% <ø> (-0.03%) ⬇️
ipld/kamt/src/kamt.rs 84.78% <ø> (ø)
---- 🚨 Try these New Features:

@Stebalien Stebalien merged commit 0426f34 into master Nov 20, 2024
14 checks passed
@Stebalien Stebalien deleted the steb/undeprecate-for-each branch November 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants