Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wasmtime to v24 #2035

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: update wasmtime to v24 #2035

merged 2 commits into from
Sep 12, 2024

Conversation

Stebalien
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.65%. Comparing base (1e31330) to head (4e15da2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fvm/src/engine/mod.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
+ Coverage   75.63%   75.65%   +0.01%     
==========================================
  Files         155      155              
  Lines       15676    15688      +12     
==========================================
+ Hits        11857    11869      +12     
  Misses       3819     3819              
Files with missing lines Coverage Δ
fvm/src/gas/price_list.rs 77.62% <ø> (ø)
fvm/src/syscalls/mod.rs 97.14% <100.00%> (ø)
fvm/src/engine/mod.rs 86.28% <87.50%> (+0.35%) ⬆️

@Stebalien
Copy link
Member Author

Ok, this appears to work: filecoin-project/lotus#12449

@rvagg
Copy link
Member

rvagg commented Sep 12, 2024

line 180 of fvm/src/engine/mod.rs, wasm_tail_call is default is now true, just needs a doc update

@Stebalien Stebalien merged commit 78228ab into master Sep 12, 2024
14 checks passed
@Stebalien Stebalien deleted the steb/update-wasmtime branch September 12, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants