docs: remove any mentions of randomness lookback limits #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't exist.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2034 +/- ##
=======================================
Coverage 75.63% 75.63%
=======================================
Files 155 155
Lines 15676 15676
=======================================
Hits 11857 11857
Misses 3819 3819 |
anorth
approved these changes
Aug 27, 2024
| /// | [`IllegalArgument`] | invalid buffer, etc. | | ||
| /// | Error | Reason | | ||
| /// |---------------------|------------------------| | ||
| /// | [`IllegalArgument`] | epoch is in the future | |
There was a problem hiding this comment.
"epoch is not a valid prior epoch number"? e.g. negatives, too
There was a problem hiding this comment.
It'll just return randomness from epoch 0. Historically it hashed it with the epoch number (giving each epoch unique randomness), now we expect that to happen in the actors themselves.
I'll document that. Also, I'll document null tipset behavior (or try to... it changes network version to network version).
jennijuju
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't exist.