-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move send/upgrade out of the kernel #1952
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1952 +/- ##
==========================================
+ Coverage 75.56% 75.60% +0.04%
==========================================
Files 157 157
Lines 15494 15473 -21
==========================================
- Hits 11708 11699 -9
+ Misses 3786 3774 -12
|
After this, the only parts remaining from #1933 are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comment, but otherwise lgtm.
Great to move the send/upgrade into these ops to make things more flexible (and remove boilerplate code)
Make them higher-level ops like everything else. I considered combining them into a single "call op" however, not all users may want to implement actor upgrading. I've also moved the generic from the methods to the trait itself. This resolves anorth's comment on the `TestKernel` by allowing additional bounds to be specified by the _implementer_, instead of having all the bounds encoded on the trait itself: > Note that KK, the type of the kernel to crate for the receiving actor, > is ignored, and Self is passed as the type parameter for the nested > call. If we could find the correct bound to specify KK for the call, > we would. This restricts the ability for the TestKernel to itself be > wrapped by another kernel type.
6a3f1ed
to
35fd780
Compare
Make them higher-level ops like everything else. I considered combining them into a single "call op" however, not all users may want to implement actor upgrading.
I've also moved the generic from the methods to the trait itself. This resolves anorth's comment on the
TestKernel
by allowing additional bounds to be specified by the implementer, instead of having all the bounds encoded on the trait itself: