-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(indexer): more clarity for ChainIndexer configuration setup #12701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure but will it be a good idea to add a commented-out config for chainidnexer the way EnableEthRPC = true
is set to true but commented in the config file by default so that it is easier for a new user.
Needs a |
unfortunately the default config is generated from settings automatically, and their values are meant to reflect what they are currently set to - so they are a kind of documentation for the user, demonstrating what the current settings are, so they have to change them if they want them. |
ahh, actually needs a |
45d5db3
to
787fa23
Compare
Feedback already suggesting that our lack of automagic config switching is leading to some confusion. I'd still rather avoid automatically turning on ChainIndexer in these cases so we'll try with more clear error messages and see if we continue to get reports.