-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] feat: ci: Automated suggestion if check-gen
job fails
#12352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated suggestion if make docgen check fails
test: bump version to make `make gen` fail
Resolve unexpected EOF error
rjan90
changed the title
[Testing] feat: ci: Automated suggestion if make docgen check fails
[Testing] feat: ci: Automated suggestion if Aug 7, 2024
check-gen
job fails
Add `actions/checkout@v4`
Add write-permissions to PRs
Read the content of the patch file before heredoc
failed, suggested fix:
To apply these changes, please review and manually apply the suggestion above. |
This was not as straightforward as I hoped - it seems like we have four options here. Given that the
|
Closing as this has been superseded by: #12681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding a new job that suggests changes if the
make docsgen
checks fail, since we already are running itIn the
check-gen
job:git diff
output to a patch file before and after runningmake docsgen-cli
.Adds a new
suggest-codegen-changes
job that:check-gen
fails and the event is a pull request.Testing:
suggest-codegen-changes
test gets skipped ifcheck-gen
passes.check-gen
job correctly creates and uploads the patch file on failure.suggest-codegen-changes
job runs as expected on PR events with failed checks.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps[skip changelog]
to the PR titleskip/changelog
to the PR