fix(httpretriever): add client headers #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
May 12, 2023
|
can't merge yet, will need to reconstruct after the squash merge of feat/http to main |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 70.93% 71.04% +0.10%
==========================================
Files 68 68
Lines 6079 6081 +2
==========================================
+ Hits 4312 4320 +8
+ Misses 1523 1520 -3
+ Partials 244 241 -3
|
hannahhoward
force-pushed
the
rvagg/client-headers
branch
from
4d4e27b
to
125a7ac
Compare
hannahhoward
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this comment by @willscott: #193 (comment)
We use
"lassie"as our default when talking to the indexer so it seems reasonable. We could add a version too?