Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fil/benchmarks #69

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fil/benchmarks #69

wants to merge 11 commits into from

Conversation

ZenGround0
Copy link
Contributor

WIP using and extending existing benchmarks to help tune filecoin hamt parameters.

hamts := []hamtParams{
hamtParams{
id: "init.AddressMap",
count: 55649,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These numbers are taken from a snapshot of chainstate two weeks ago. We will want to change them periodically to run benchmarks that are relevant. For the final v3 tuning we will want to extrapolate values we expect a few months out. Merging temporary values to master is ugly but setting values in source is a nice lightweight mechanism for updating.

}
}

func doBenchmarkResetSuite(num int, bitWidth int, datasize int, keysize int) func(b *testing.B) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this benchmark for resetting the set of existing keys to better match the expected workloads on some filecoin state tree HAMTs, i.e. power.Claims.

@@ -0,0 +1,24 @@
# Benchparse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense to extract this from this package so we can avoid perf dep in HAMT. Additionally I expect to tweak and use this for measuring AMT so decoupling might make logical sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably.

@ZenGround0 ZenGround0 marked this pull request as ready for review November 24, 2020 16:17
@ZenGround0
Copy link
Contributor Author

@acruikshank couldn't tag you for review but please take a look

FYI @anorth @Stebalien @rvagg

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level looks good

@@ -0,0 +1,24 @@
# Benchparse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants