Generate unique beacon per each fake EC tipset #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate a unique bacon per each tipset created by fake ec for better testing.
masih
force-pushed
the
masih/fake-ec-tipset-beacon
branch
from
301b697
to
6d150a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 69.58% 69.32% -0.27%
==========================================
Files 74 74
Lines 7497 7494 -3
==========================================
- Hits 5217 5195 -22
- Misses 1868 1885 +17
- Partials 412 414 +2
|
Stebalien
approved these changes
Nov 21, 2024
Kubuxu
reviewed
Nov 21, 2024
| @@ -159,15 +145,22 @@ func (ec *FakeEC) genTipset(epoch int64) *tipset { | |||
| tsk = append(tsk, cidPrefixBytes...) | |||
| tsk = append(tsk, digest...) | |||
| } | |||
|
|
|||
| h.Reset() | |||
| h.Write([]byte(fmt.Sprintf("beacon %d", epoch))) | |||
There was a problem hiding this comment.
I would make it dependant on seed but not critical and for sure better than it was.
There was a problem hiding this comment.
The hasher h is keyed by seed already. That should do it right?
There was a problem hiding this comment.
Ahh, you are probably right. I forgot that we have a keyed hasher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a unique bacon per each tipset created by fake ec for better testing.