Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use cert pointer in verification #751

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

masih
Copy link
Member

@masih masih commented Nov 21, 2024

The finality certificate APIs at times switch between pointer and values. This introduces the need for extra gymnastics when validating certs, where a slice of cert pointers need to be converted to values to use the cert verification APIs.

Instead, consistently accept pointers to certs.

The finality certificate APIs at times switch between pointer and
values. This introduces the need for extra gymnastics when validating
certs, where a slice of cert pointers need to be converted to values to
use the cert verification APIs.

Instead, consistently accept pointers to certs.
@masih masih requested a review from Kubuxu November 21, 2024 15:23
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (c92e6d4) to head (a64e637).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   69.80%   69.40%   -0.41%     
==========================================
  Files          74       74              
  Lines        7497     7497              
==========================================
- Hits         5233     5203      -30     
- Misses       1856     1880      +24     
- Partials      408      414       +6     
Files with missing lines Coverage Δ
certexchange/polling/poller.go 79.38% <100.00%> (ø)
certs/certs.go 92.68% <100.00%> (ø)
host.go 62.66% <100.00%> (-3.90%) ⬇️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

@masih masih added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 6b6b5c5 Nov 21, 2024
13 checks passed
@masih masih deleted the masih/finality-cert-pointer branch November 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants