Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more logs on manifest and initial power table #714

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

hanabi1224
Copy link
Contributor

This PR adds more F3 startup logs for easier troubleshooting.

After the change:

...
2024-10-15T13:15:14.693+0800    INFO    f3      go-f3/store.go:50       loaded initial power table at epoch 1860: bafy2bzaced6vgp6agebcyymrmh3q2r6gmiz3owb2b7kz5h744u7frlkdpg3qy
...
2024-10-15T13:15:14.704+0800    INFO    f3      go-f3/f3.go:200 F3 is starting  {"initialDelay": 0, "hasPendingManifest": false, "NetworkName": "butterflynet", "bootstrapEpoch": 2760, "finality": 900, "initialPowerTable": "b"}

@hanabi1224 hanabi1224 marked this pull request as ready for review October 15, 2024 05:17
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (25c3ade) to head (f7e0500).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
store.go 40.00% 2 Missing and 1 partial ⚠️
f3.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   76.28%   74.79%   -1.50%     
==========================================
  Files          69       69              
  Lines        5584     6928    +1344     
==========================================
+ Hits         4260     5182     +922     
- Misses        912     1331     +419     
- Partials      412      415       +3     
Files with missing lines Coverage Δ
f3.go 61.53% <66.66%> (-7.73%) ⬇️
store.go 48.71% <40.00%> (-8.98%) ⬇️

... and 55 files with indirect coverage changes

f3.go Outdated Show resolved Hide resolved
store.go Show resolved Hide resolved
@Stebalien Stebalien added this pull request to the merge queue Oct 24, 2024
Merged via the queue into filecoin-project:main with commit 5fc96af Oct 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants