Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the given context on F3 broadcast message #706

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

masih
Copy link
Member

@masih masih commented Oct 8, 2024

Respect the given context when broadcasting messages in F3 instead of using the internal running context.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (9ec9a0e) to head (2dafa25).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   76.54%   76.30%   -0.24%     
==========================================
  Files          69       69              
  Lines        5584     5584              
==========================================
- Hits         4274     4261      -13     
- Misses        901      912      +11     
- Partials      409      411       +2     
Files with missing lines Coverage Δ
f3.go 67.88% <100.00%> (ø)
host.go 66.60% <100.00%> (-3.50%) ⬇️

... and 2 files with indirect coverage changes

@masih masih force-pushed the masih/fix-broadcast-ctx-pass branch from ab8a868 to de62489 Compare October 8, 2024 13:14
Respect the given context when broadcasting messages in F3 instead of
using the internal running context.
@masih masih force-pushed the masih/fix-broadcast-ctx-pass branch from de62489 to 2dafa25 Compare October 8, 2024 14:27
@masih masih requested a review from Stebalien October 8, 2024 14:27
@masih masih marked this pull request as ready for review October 8, 2024 14:27
@Stebalien Stebalien added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit f638813 Oct 8, 2024
13 checks passed
@Stebalien Stebalien deleted the masih/fix-broadcast-ctx-pass branch October 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants