-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import go-log directly (except in GPBFT) and remove Logging #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/remove-logging-param
branch
from
July 8, 2024 09:52
3082d82
to
1eb3849
Compare
Kubuxu
reviewed
Jul 8, 2024
Kubuxu
reviewed
Jul 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 74.77% 74.36% -0.42%
==========================================
Files 41 42 +1
Lines 3719 3713 -6
==========================================
- Hits 2781 2761 -20
- Misses 657 665 +8
- Partials 281 287 +6
|
Stebalien
force-pushed
the
steb/remove-logging-param
branch
from
July 8, 2024 10:01
1eb3849
to
dae94a7
Compare
It was causing circular import issues (which could have been fixed by moving it, I guess) but, more importantly, the abstraction really wasn't pulling its weight. We're keeping it out of GPBFT itself but our other packages already depend on things like go-datastore and go-libp2p, so depending on go-log doesn't really matter.
Stebalien
force-pushed
the
steb/remove-logging-param
branch
from
July 8, 2024 10:03
dae94a7
to
1a54c2c
Compare
Kubuxu
reviewed
Jul 8, 2024
Kubuxu
reviewed
Jul 8, 2024
Kubuxu
reviewed
Jul 8, 2024
Kubuxu
reviewed
Jul 8, 2024
Kubuxu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was causing circular import issues (which could have been fixed by moving it, I guess) but, more importantly, the abstraction really wasn't pulling its weight. We're keeping it out of GPBFT itself but our other packages already depend on things like go-datastore and go-libp2p, so depending on go-log doesn't really matter.