Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of signatures to 96 bytes #423

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jul 7, 2024

96 is the size of the compressed representation of BLS-381 G2 point, which is the scheme we use for signatures. It is the larger of two possibilities, with signatures on G1 being 48 bytes.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (b5674db) to head (d8296fe).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   74.15%   74.42%   +0.26%     
==========================================
  Files          39       39              
  Lines        3753     3753              
==========================================
+ Hits         2783     2793      +10     
+ Misses        691      684       -7     
+ Partials      279      276       -3     
Files Coverage Δ
gpbft/gpbft.go 86.00% <ø> (+0.27%) ⬆️

... and 5 files with indirect coverage changes

@Kubuxu Kubuxu added this pull request to the merge queue Jul 7, 2024
Merged via the queue into main with commit 0bc5cca Jul 7, 2024
13 checks passed
@Kubuxu Kubuxu deleted the feat/harden-sig-cborgen branch July 7, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants