Improve lifecycle management #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 74.45% 74.45%
=======================================
Files 39 41 +2
Lines 3754 3719 -35
=======================================
- Hits 2795 2769 -26
+ Misses 683 666 -17
- Partials 276 284 +8
|
Stebalien
force-pushed
the
steb/fix-tests
branch
2 times, most recently
from
9a5d293
to
65eb1ac
Compare
Stebalien
commented
Jul 6, 2024
Stebalien
commented
Jul 6, 2024
Stebalien
force-pushed
the
steb/fix-tests
branch
2 times, most recently
from
4c77453
to
cf135ad
Compare
Stebalien
commented
Jul 6, 2024
Stebalien
force-pushed
the
steb/fix-tests
branch
4 times, most recently
from
814a237
to
b76a60c
Compare
Stebalien
commented
Jul 6, 2024
1. Merge the client and the runner. The distinction was unclear and the client/runner/module tended to reach into each other. This change merges the client/runner and then separates the new "runner" from the module as much as possible. 2. Completely stop/discard the runner when rebootstrapping. The new logic carefully waits for all components to stop before moving on. 3. Simplify locking and make sure we take the locks where appropriate. 4. Merge bootstrap and re-configure logic. The dynamic manifest client no longer cares about _when_ a manifest should be applied, it simply gives it to the module (F3) and let's F3 us its normal bootstrap logic. Finally, I've improved the tests to: 1. Always on exit (checking for errors). 2. Never fail from goroutines. 3. Correctly wait for manifest changes (previously, it would wait for at least one node to change manifests). NOTEs: 1. This removes the ability to reconfig without rebootstrap, but preserves the ability to _pause_ without rebootstrap. 2. This causes bootstrap to start at the time the bootstrap epoch _should_ have happened instead of starting at the next non-null epoch. In practice, this should behave better as all nodes will start at the same time (and will look back 900 epochs anyways).
Stebalien
commented
Jul 6, 2024
Stebalien
commented
Jul 6, 2024
Kubuxu
reviewed
Jul 7, 2024
Kubuxu
reviewed
Jul 7, 2024
Kubuxu
reviewed
Jul 7, 2024
Kubuxu
reviewed
Jul 7, 2024
Kubuxu
reviewed
Jul 7, 2024
Kubuxu
approved these changes
Jul 7, 2024
And have the test chain "catch up" if it's too far behind.
Kubuxu
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I've improved the tests to:
NOTE: This removes the ability to reconfig without rebootstrap, but preserves the ability to pause without rebootstrap.