Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(f3): handle failure to receive manifest from the client #298

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(f3): handle failure to receive manifest from the client #298

merged 1 commit into from
Oct 24, 2024

Conversation

Stebalien
Copy link
Member

If we keep going here, we'll panic. See (also includes a regression test):

filecoin-project/lotus#12634

@Stebalien
fix(f3): handle failure to receive manifest from the client
79b5757 
If we keep going here, we'll panic. See (also includes a regression test):

filecoin-project/lotus#12634
@Stebalien Stebalien mentioned this pull request Oct 24, 2024
Merged
8 tasks
magik6k
magik6k approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately that's fine - task handlers catch panics and should correctly retry

@magik6k magik6k merged commit 4440241 into filecoin-project:main Oct 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k