Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: F3 #292

Merged
merged 7 commits into from
Oct 22, 2024
Merged

feat: F3 #292

merged 7 commits into from
Oct 22, 2024

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Oct 21, 2024

No description provided.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems reasonable. My comments are mostly opinionated nits from someone who really has no say in how you write code, so feel free to ignore them and focus on the questions.

harmony/taskhelp/common.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Outdated Show resolved Hide resolved
tasks/f3/f3_task.go Show resolved Hide resolved
@magik6k magik6k requested review from Stebalien and LexLuthr and removed request for Stebalien October 22, 2024 07:34
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation and config to control participation.

tasks/f3/f3_task.go Show resolved Hide resolved
@magik6k
Copy link
Collaborator Author

magik6k commented Oct 22, 2024

Needs documentation and config to control participation.

Not sure about config, we can add a flag matching the lotus one for disabling, but iiuc SPs are never supposed to mine without participating in F3

@LexLuthr LexLuthr merged commit c6988ed into main Oct 22, 2024
28 checks passed
@LexLuthr LexLuthr deleted the feat/cf3 branch October 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants