-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sector selection in snap ingester #137
Conversation
fbefb2e
to
23a3391
Compare
The last commit implements the fix also done in filecoin-project/lotus#12342; We'll also need that for PoRep side, opened an issue for it - #138 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We missed an important point. If a sector is extended using sptool
then our DB would not know about it. Thus our sector selection is never going to be correct. We need a IAmBored job which updated the sector expiration every few hours in the DB. Only for sector_meta table.
Or we can check expiration of each sector online and then do the selection.
IAmBored seems a cleaner approach.
We have that: https://github.com/filecoin-project/curio/blob/main/tasks/metadata/task_sector_expirations.go |
I don't know how I missed that. 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90 days grace period is a f05 market deal thing and not part of power/miner actor.
Should address all concerns from #104
Definitely fixes sector selection logic.