feat(events): split up verifier_balance event into 4 #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add_verifier * remove_verifier * allocate_datacap (client) * remove_datacap (client, not previously covered)
rvagg
force-pushed
the
rvagg/actor-event-updates-verifier_balance
branch
from
64bb98c
to
028adb7
Compare
|
@rvagg Please can you remove the draft status from this so I can merge it the parent branch and get it to a completed state ? |
|
@rvagg Looks like we got rid of the verifier balance event alltogether. We should keep it around as it is a useful aggregate event. |
That was my proposal in filecoin-project/FIPs#754 (comment). I'm not sure what value it adds now as its information is identical to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR against #1531
Ref: filecoin-project/FIPs#754 (comment)