Replace Map with Map2 in miner actor #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Feb 23, 2024
| "failed to construct empty precommit map", | ||
| ) | ||
| })?; | ||
| PreCommitMap::empty(store, PRECOMMIT_CONFIG, "precommits").flush()?; |
There was a problem hiding this comment.
Suggested change
| PreCommitMap::empty(store, PRECOMMIT_CONFIG, "precommits").flush()?; | |
| PreCommitMap::empty(store, PRECOMMIT_CONFIG, "pre_committed_sectors").flush()?; |
Maybe stick to names that match the state names so there's no ambiguity? There's a lot of these to replace though. s/"precommits"/"pre_committed_sectors"/g
There was a problem hiding this comment.
This is not a bad suggestion, but is not the existing pattern (all by me) either. The labels here are for easy reading independent of renames that might happen in the code. The code names are not necessarily good, and some such collections are not even named (when nested in others).
E.g. in the market
SectorDealsMap::load(store, sectors_root, SECTOR_DEALS_CONFIG, "sector deals")
rvagg
approved these changes
Feb 23, 2024
Stebalien
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1346. This is the last direct use of
Mapby actors, the others are embedded inside other structures likeSet.