fix: explicitly specify HAMT bitwidths everywhere #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitting this now so, e.g., #1362 will pass the tests again. It's failing right now due to deprecation warnings. |
|
Oh. Well, I guess we should merge #1363 first. |
|
I don't really mind this, but I'm going to fix it better e.g. in #1363 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
+ Coverage 90.75% 90.76% +0.01%
==========================================
Files 145 145
Lines 27277 27286 +9
==========================================
+ Hits 24755 24767 +12
+ Misses 2522 2519 -3
|
This _doesn't_ migrate to the new `Map2` interface everywhere, it just avoids the use of `Hamt::load` and `Hamt::new`, which will be deprecated in the next release of `fvm_ipld_hamt`. part of #1346
Stebalien
force-pushed
the
steb/avoid-hamt-load-new
branch
from
cae9631
to
076159d
Compare
|
The change is pretty minimal so I'm just going to let it merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't migrate to the new
Map2interface everywhere, it just avoids the use ofHamt::loadandHamt::new, which will be deprecated in the next release offvm_ipld_hamt.part of #1346