Initial implementation of new, more convenient Map wrapping HAMT #1349
Conversation
|
@Stebalien can you help me figure out how to take the key as a reference? I was hoping to simplify callers by setting the key type as |
anorth
force-pushed
the
anorth/map2
branch
2 times, most recently
from
a7b581f
to
f2c6bfc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 90.19% 90.72% +0.53%
==========================================
Files 144 145 +1
Lines 27457 27427 -30
==========================================
+ Hits 24764 24884 +120
+ Misses 2693 2543 -150
|
anorth
force-pushed
the
anorth/map2
branch
2 times, most recently
from
b33527f
to
aa0f2b4
Compare
anorth
force-pushed
the
anorth/map2
branch
2 times, most recently
from
beed0f4
to
d1b003a
Compare
runtime/src/util/map.rs
Outdated
| K: MapKey, | ||
| V: DeserializeOwned + Serialize, | ||
| { | ||
| hamt: hamt::Hamt<&'bs BS, V, hamt::BytesKey, Hasher>, |
There was a problem hiding this comment.
nit: I'd make this own the underlying blockstore. There's a blanket Blockstore for &Blockstore impl anyways.
There was a problem hiding this comment.
I.e., even if it owns the blockstore, you can still use Map2<&SomeBS, ...>.
runtime/src/util/map.rs
Outdated
|
|
||
| impl MapKey for u64 { | ||
| fn from_bytes(b: &[u8]) -> Result<Self, String> { | ||
| let (v, _) = unsigned_varint::decode::u64(b).map_err(|e| e.to_string())?; |
There was a problem hiding this comment.
I would validate that b doesn't contain any extra bytes.
Work towards #1346, as well as a general improvement in noisy code.