Update the builtin actors to expose create entrypoints
#1339
+354
−357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A skim looked ok to me, but I've tagged @Stebalien for detailed review. Will there be a FIP for this VM change which discusses the design tradeoffs involved in the approach generally? |
|
There will absolutely be a FIP (and some discussion, we haven't landed on the final design yet). I'll review this and the related PRs this coming week. Thanks @sistemd! ❤️ |
|
Reverting to draft until the FIP etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM module level
createfunctions were added in filecoin-project/ref-fvm#1821, and this PR adds support for them in the builtin actors. Only the unit tests for each individual test are passing, as well as the integration tests in theref-fvmrepo. I'll update all of the other tests once I get some general approval on the approach taken in this PR and filecoin-project/ref-fvm#1821.