-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automate creation of GitHub releases and tags #235
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2590f9b
ci: automate creation of GitHub releases and tags
galargh 7be3b54
chore: limit released packages and update separator
galargh 58afb97
ci: limit duplication in release workflows
galargh 8bf8079
Merge branch 'main' into ipdx/unified-github-workflows
Stebalien e4daf65
docs: document the new release process and possible improvements
galargh 90b66b4
chore: apply suggestions from code review
galargh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Release Checker | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| paths: [ | ||
| "dispatch_examples/greeter/Cargo.toml", | ||
| "frc42_dispatch/Cargo.toml", | ||
| "frc42_dispatch/hasher/Cargo.toml", | ||
| "frc42_dispatch/macros/Cargo.toml", | ||
| "frc42_dispatch/macros/example/Cargo.toml", | ||
| "frc46_token/Cargo.toml", | ||
| "frc53_nft/Cargo.toml", | ||
| "fvm_actor_utils/Cargo.toml", | ||
| "fvm_dispatch_tools/Cargo.toml", | ||
| "testing/integration/Cargo.toml", | ||
| "testing/test_actors/Cargo.toml", | ||
| "testing/test_actors/actors/basic_nft_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_receiving_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_token_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_transfer_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc53_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_token/token_impl/Cargo.toml" | ||
| ] | ||
galargh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| types: [ opened, synchronize, reopened, labeled, unlabeled ] | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| release-check: | ||
| uses: ipdxco/unified-github-workflows/.github/workflows/[email protected] | ||
| with: | ||
| sources: | | ||
galargh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| [ | ||
| "dispatch_examples/greeter/Cargo.toml", | ||
galargh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "frc42_dispatch/Cargo.toml", | ||
| "frc42_dispatch/hasher/Cargo.toml", | ||
| "frc42_dispatch/macros/Cargo.toml", | ||
| "frc42_dispatch/macros/example/Cargo.toml", | ||
| "frc46_token/Cargo.toml", | ||
| "frc53_nft/Cargo.toml", | ||
| "fvm_actor_utils/Cargo.toml", | ||
| "fvm_dispatch_tools/Cargo.toml", | ||
| "testing/integration/Cargo.toml", | ||
| "testing/test_actors/Cargo.toml", | ||
| "testing/test_actors/actors/basic_nft_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_receiving_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_token_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_transfer_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc53_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_token/token_impl/Cargo.toml" | ||
| ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Releaser | ||
|
|
||
| on: | ||
| push: | ||
| paths: [ | ||
| "dispatch_examples/greeter/Cargo.toml", | ||
galargh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "frc42_dispatch/Cargo.toml", | ||
| "frc42_dispatch/hasher/Cargo.toml", | ||
| "frc42_dispatch/macros/Cargo.toml", | ||
| "frc42_dispatch/macros/example/Cargo.toml", | ||
| "frc46_token/Cargo.toml", | ||
| "frc53_nft/Cargo.toml", | ||
| "fvm_actor_utils/Cargo.toml", | ||
| "fvm_dispatch_tools/Cargo.toml", | ||
| "testing/integration/Cargo.toml", | ||
| "testing/test_actors/Cargo.toml", | ||
| "testing/test_actors/actors/basic_nft_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_receiving_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_token_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_transfer_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc53_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_token/token_impl/Cargo.toml" | ||
| ] | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.sha }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| releaser: | ||
| uses: ipdxco/unified-github-workflows/.github/workflows/[email protected] | ||
| with: | ||
| sources: | | ||
| [ | ||
| "dispatch_examples/greeter/Cargo.toml", | ||
| "frc42_dispatch/Cargo.toml", | ||
| "frc42_dispatch/hasher/Cargo.toml", | ||
| "frc42_dispatch/macros/Cargo.toml", | ||
| "frc42_dispatch/macros/example/Cargo.toml", | ||
| "frc46_token/Cargo.toml", | ||
| "frc53_nft/Cargo.toml", | ||
| "fvm_actor_utils/Cargo.toml", | ||
| "fvm_dispatch_tools/Cargo.toml", | ||
| "testing/integration/Cargo.toml", | ||
| "testing/test_actors/Cargo.toml", | ||
| "testing/test_actors/actors/basic_nft_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_receiving_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_token_actor/Cargo.toml", | ||
| "testing/test_actors/actors/basic_transfer_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc53_test_actor/Cargo.toml", | ||
| "testing/test_actors/actors/frc46_factory_token/token_impl/Cargo.toml" | ||
| ] | ||
| secrets: | ||
| UCI_GITHUB_TOKEN: ${{ secrets.UCI_GITHUB_TOKEN }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This set of files is duplicated 4 times across 2 files. Is there a way to factor it out to one place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, that isn't that straighforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack - bummer. I guess this in part because GitHub Actions doesn't support YML anchors?
Maybe for now just add a comment that any changes here should also be made in releaser.yml (and vice versa)