feat: SDK::send returns ExitCode and Option<IpldBlock> #177
Conversation
arajasek
force-pushed
the
asr/ipld-block-master
branch
from
064ee7e
to
4c5d9d1
Compare
fvm_actor_utils/src/receiver/mod.rs
Outdated
| @@ -132,16 +147,16 @@ impl<T: RecipientData> ReceiverHook<T> { | |||
| &TokenAmount::zero(), | |||
| )?; | |||
|
|
|||
| match receipt.exit_code { | |||
| match ret.0 { | |||
There was a problem hiding this comment.
Ok, I think we want to name the return struct. This is going to get confusing.
arajasek
force-pushed
the
asr/ipld-block-master
branch
2 times, most recently
from
2ffd727
to
882fb5c
Compare
arajasek
force-pushed
the
asr/ipld-block-master
branch
from
882fb5c
to
84801dd
Compare
frc46_token/src/token/types.rs
Outdated
| @@ -118,7 +118,7 @@ pub struct MintReturn { | |||
| pub balance: TokenAmount, | |||
| /// The new total supply. | |||
| pub supply: TokenAmount, | |||
| /// (Optional) data returned from receiver hook | |||
| /// (Optional) CBOR-encoded data returned from receiver hook | |||
There was a problem hiding this comment.
I don't think anything here forces this to be CBOR, and this comment is likely to rot. cc @Stebalien
There was a problem hiding this comment.
We should probably just switch this over to Option<IpldBlock> (or actually check the codec).
There was a problem hiding this comment.
I think you're both right -- I'm gonna open an issue to make this change. It shouldn't be too hard to do, but I don't wanna increase the scope of this PR.
@anorth I will revert the change to the comment, though.
fvm_actor_utils/src/messaging.rs
Outdated
| @@ -51,6 +50,21 @@ impl From<&MessagingError> for ExitCode { | |||
| } | |||
| } | |||
|
|
|||
| /// Matches the SDK's Response type | |||
| /// We duplicate the type here, because this trait must be implemented | |||
There was a problem hiding this comment.
Sorry, I'm referring to the Messaging trait below -- I'll clarify.
frc46_token/src/token/types.rs
Outdated
| @@ -118,7 +118,7 @@ pub struct MintReturn { | |||
| pub balance: TokenAmount, | |||
| /// The new total supply. | |||
| pub supply: TokenAmount, | |||
| /// (Optional) data returned from receiver hook | |||
| /// (Optional) CBOR-encoded data returned from receiver hook | |||
There was a problem hiding this comment.
We should probably just switch this over to Option<IpldBlock> (or actually check the codec).
Integrates filecoin-project/ref-fvm#1366