Update fip-0077.md specification #963

ipfsforcezuofu · 2024-03-17T03:41:01Z

The specification has been updated to address previous feedback. And a formula for calculating the deposit amount has been drafted. In response to concerns about variable deposit amounts, it is proposed that the message for insufficient deposits will now specify the exact amount needed to meet the deposit requirement.

ipfsforcezuofu · 2024-03-17T03:54:58Z

The specification has been updated to address previous feedback. And a formula for calculating the deposit amount has been drafted. In response to concerns about variable deposit amounts, it is proposed that the message for insufficient deposits will now specify the exact amount needed to meet the deposit requirement.

ipfsforcezuofu · 2024-03-17T03:55:20Z

The specification has been updated to address previous feedback. And a formula for calculating the deposit amount has been drafted. In response to concerns about variable deposit amounts, it is proposed that the message for insufficient deposits will now specify the exact amount needed to meet the deposit requirement.

luckyparadise · 2024-03-18T16:23:19Z

Are you drafting a new FIP?

Please follow these guidelines to help ensure that your proposal is set up for success in the governance process.

Open a discussion topic

Changes to the Filecoin core protocol proceed through open discussion. Please open a new discussion topic in the FIPs repository discussion board and outline you motivation and proposal.

The FIP format is suitable for specifying a concrete protocol change for implementation, but your discussion post should describe more of the background and problem to be solved, outline a range of approaches and their tradeoffs, and invite participants to explore other solutions.

Historically, failing to gain some community buy-in before submitting a FIP has often resulted in rejected FIPs and much wasted effort.

Please use the template

Please draft your FIP by starting with an appropriate template file from templates directory. Do not significantly change the header table format or section headings.

Don't claim a FIP number

FIP numbers are allocated by the FIP editors when a draft is ready to be merged into the master branch. The editors coordinate to ensure allocations to in-flight drafts don't collide. Please do not allocate yourself a FIP number.

Name your file fip-my_draft_title.md (replacing the suffix with an abbreviated title) and leave "to be assigned" for the FIP number in the header table. A FIP editor will either inform you of the appropriate number, or insert it themselves when merging.

Please add your FIP to the README

The top-level README.md file contains a table of all FIPs. Please add yours there in the same PR that adds the FIP draft itself. Use XXXX for the FIP number until it is assigned by an editor.

Delete this guidance and describe your FIP

Once you've followed the guidance above and are ready to submit your FIP draft, please delete this text and replace it with a copy of the Abstract from your draft, and a link to the relevant discussion forum topic.

@ipfsforcezuofu could you delete the template text from the description box and include the details of this PR request there instead? I see you wrote it down as a comment but it will be more helpful if it is stated in the description box. Thanks!

ipfsforcezuofu · 2024-03-19T01:07:13Z

thanks @luckyparadise
Please kindly check that PR description has been modified and that the template text has been removed.

jsoares

I feel like the mechanisms are a bit underspecified, or at least lacking some rigour, but will let others opine. In the meantime, here are some formatting and clarity improvements.

jsoares · 2024-03-19T13:04:18Z

FIPS/fip-0077.md

- Proposed:   
-Require transfer a certain amount of money to the miner's account as locked reward, and the amount of this money depends on the pledge required to reach the network's block production threshold.
+To combat spamming, a deposit reflecting the opportunity cost is proposed for each new miner creation, detailed as follows:
+### Deposit Amount Calculation:


Suggested change

### Deposit Amount Calculation:

### Deposit Amount Calculation

jsoares · 2024-03-19T13:04:23Z

FIPS/fip-0077.md

+### Deposit Amount Calculation:
+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.
+### Vesting Schedule:


Suggested change

### Vesting Schedule:

### Vesting Schedule

jsoares · 2024-03-19T13:04:28Z

FIPS/fip-0077.md

+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.
+### Vesting Schedule:
+Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.
+### Handling Deposit Discrepancies:


Suggested change

### Handling Deposit Discrepancies:

### Handling Deposit Discrepancies

jsoares · 2024-03-19T13:04:56Z

FIPS/fip-0077.md

+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.


Suggested change

The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.

This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.

The deposit amount will be based on a waterline storage deposit of 10 TiB, defined in the MINIMUM_CONSENSUS_POWER constant.

This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/TiB as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.

I suppose this is what you meant

jsoares · 2024-03-19T13:06:52Z

FIPS/fip-0077.md

+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.


Is the final formula just MINIMUM_CONSENSUS_POWER x StateMinerInitialPledgeCollateral? If so, that should be clearly written as the text can be interpreted in different ways.

jennijuju · 2024-03-20T13:17:33Z

FIPS/fip-0077.md

-Require transfer a certain amount of money to the miner's account as locked reward, and the amount of this money depends on the pledge required to reach the network's block production threshold.
+To combat spamming, a deposit reflecting the opportunity cost is proposed for each new miner creation, detailed as follows:
+### Deposit Amount Calculation:
+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.


Suggested change

The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.

The deposit amount will be based on a waterline storage deposit of 10TiB, defined in the MINIMUM_CONSENSUS_POWER constant.

jennijuju · 2024-03-20T13:18:42Z

FIPS/fip-0077.md

+To combat spamming, a deposit reflecting the opportunity cost is proposed for each new miner creation, detailed as follows:
+### Deposit Amount Calculation:
+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.


Suggested change

This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.

This base amount will be multiplied by the Initial Pledge, approximately 5.5 FIL/TiB as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.

jennijuju · 2024-03-20T13:20:32Z

FIPS/fip-0077.md

+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.
+### Vesting Schedule:
+Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.


Suggested change

Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.

Deposited funds will be locked 180 days, similar to a portion of block rewards are locked for 180 days before they are released to SP, representing the opportunity cost and ensuring funds are temporarily inaccessible.

maybe we shouly released to miner

jennijuju · 2024-03-20T13:22:46Z

FIPS/fip-0077.md

+### Vesting Schedule:
+Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.
+### Handling Deposit Discrepancies:
+If the deposit is insufficient, the user will be notified of the exact amount required to proceed.


This seems like a client implementation detail. For this spec, maybe consider to rephrase this as "Miner actor creation will fail if user fail to provide sufficient deposit."

@jennijuju thank you for your suggestion. I will modify the statement to reflect that miner actor creation will fail due to insufficient deposit, and I will also include details about the exact deposit amount required. This adjustment aims to address concerns regarding variable deposit amounts.

jennijuju · 2024-03-20T13:23:37Z

FIPS/fip-0077.md

+Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.
+### Handling Deposit Discrepancies:
+If the deposit is insufficient, the user will be notified of the exact amount required to proceed.
+Surplus deposits will be refunded to the Storage Provider's (SP) balance, ensuring only the necessary funds are locked.


Suggested change

Surplus deposits will be refunded to the Storage Provider's (SP) balance, ensuring only the necessary funds are locked.

Surplus deposits will be added to the Storage Provider's (SP) available balance, ensuring only the necessary funds are locked.

anorth

There's a lot more detail in filecoin-project/builtin-actors#1535. Some of this will need to be translated to the FIP as specification.

anorth · 2024-04-04T19:16:05Z

FIPS/fip-0077.md

+The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
+This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.
+### Vesting Schedule:
+Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.


Exactly 180 days as a cliff, or a ramped release? Is the proposal to use the existing vesting table data structure for this? That would be fine, but needs to be stated.

ipfsforcezuofu · 2024-04-16T09:33:50Z

As suggested by @lucky N. _FF. The PR is closed for now and will be reopened once the implementation details are finalized.

Update fip-0077.md specification

863b3fc

ipfsforcezuofu requested review from momack2, arajasek, jennijuju, kaitlin-beegle, anorth, raulk, jsoares and TippyFlitsUK as code owners March 17, 2024 03:41

ipfsforcezuofu closed this Mar 17, 2024

ipfsforcezuofu deleted the ipfsforcezuofu-patch-1 branch March 17, 2024 03:58

ipfsforcezuofu restored the ipfsforcezuofu-patch-1 branch March 17, 2024 04:00

ipfsforcezuofu reopened this Mar 17, 2024

jsoares reviewed Mar 19, 2024

View reviewed changes

jennijuju reviewed Mar 20, 2024

View reviewed changes

This was referenced Mar 27, 2024

feat: add miner deposit ipfs-force-community/builtin-actors#10

Merged

Feat/add miner deposit v3 filecoin-project/builtin-actors#1535

Open

anorth reviewed Apr 4, 2024

View reviewed changes

ipfsforcezuofu closed this Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fip-0077.md specification #963

Update fip-0077.md specification #963

ipfsforcezuofu commented Mar 17, 2024 •

edited

Loading

ipfsforcezuofu commented Mar 17, 2024

ipfsforcezuofu commented Mar 17, 2024

luckyparadise commented Mar 18, 2024

Are you drafting a new FIP?

Open a discussion topic

Please use the template

Don't claim a FIP number

Please add your FIP to the README

Delete this guidance and describe your FIP

ipfsforcezuofu commented Mar 19, 2024

jsoares left a comment

jsoares Mar 19, 2024

jsoares Mar 19, 2024

jsoares Mar 19, 2024

jsoares Mar 19, 2024

jsoares Mar 19, 2024

jennijuju Mar 20, 2024

jennijuju Mar 20, 2024

jennijuju Mar 20, 2024

tediou5 Mar 28, 2024

jennijuju Mar 20, 2024

ipfsforcezuofu Mar 21, 2024

jennijuju Mar 20, 2024

anorth left a comment

anorth Apr 4, 2024

ipfsforcezuofu commented Apr 16, 2024

	### Deposit Amount Calculation:

	### Deposit Amount Calculation

	### Handling Deposit Discrepancies:

	### Handling Deposit Discrepancies

		The deposit amount will be based on a waterline storage deposit of 10t, defined in the MINIMUM_CONSENSUS_POWER constant.
		This base amount will be multiplied by the sealing cost pledge, approximately 5.5 FIL/t as of 3/16/2024, as determined by StateMinerInitialPledgeCollateral. This reflects the economic conditions of the network.

	Deposited funds will be locked as rewards for 180 days, representing the opportunity cost and ensuring funds are temporarily inaccessible.
	Deposited funds will be locked 180 days, similar to a portion of block rewards are locked for 180 days before they are released to SP, representing the opportunity cost and ensuring funds are temporarily inaccessible.

	Surplus deposits will be refunded to the Storage Provider's (SP) balance, ensuring only the necessary funds are locked.
	Surplus deposits will be added to the Storage Provider's (SP) available balance, ensuring only the necessary funds are locked.

Update fip-0077.md specification #963

Update fip-0077.md specification #963

Conversation

ipfsforcezuofu commented Mar 17, 2024 • edited Loading

ipfsforcezuofu commented Mar 17, 2024

ipfsforcezuofu commented Mar 17, 2024

luckyparadise commented Mar 18, 2024

Are you drafting a new FIP?

Open a discussion topic

Please use the template

Don't claim a FIP number

Please add your FIP to the README

Delete this guidance and describe your FIP

ipfsforcezuofu commented Mar 19, 2024

jsoares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anorth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ipfsforcezuofu commented Apr 16, 2024

ipfsforcezuofu commented Mar 17, 2024 •

edited

Loading