Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #36 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #36 #37

wants to merge 1 commit into from

Conversation

D063520
Copy link

@D063520 D063520 commented Feb 22, 2019

Entity is also imported if there exists already an entity with the same label in one language.

@lucaswerkmeister
Copy link
Contributor

Entity is also imported if there exists already an entity with the same label in one language.

Can you clarify whether that’s the current behavior (without the PR) or the one introduced by this PR? At least when I used WikibaseImport in combination with WikibaseQualityConstraints, I wanted entities to not be imported if they already existed.

@D063520
Copy link
Author

D063520 commented Feb 27, 2019

This is the new behavior. The problem was that in Wikidata there are different entities with exactly the same label in at least one language. See the corresponding issue for an example. So he import was prevented. If the entity was already imported from Wikidata it will not be imported again since the tool keeps track of the already imported entities in the database. If the user has created already an entity with the same name he must merge the entities afterwards I would say. But preventing the import at all will not help, or?

@D063520
Copy link
Author

D063520 commented Jun 11, 2019

Hi,

can we discuss more about this commit .... My problem is that I cannot import some entities like the EU on a fresh installation which is something I really would expect to work. The reason is that two properties of EU with different Q-id have the same label in some strange language, namely latvisk. This is the workaround I found.
Entities with the same Q in wikidata will NOT be reinserted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants