-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - started a page for opm coregistration #764
Conversation
should we fix the polhemus file on disk (silently) so that the flip of the left and right fiducial does not have to be explained? I think it distracts |
Or perhaps make it an example script (and include there the strategy to fix by manipulating the pos file?) |
…ile which is to be used
Left-right flips happen not too often, but can be everywhere in the acquisition and in the analysis. I would not spend time explaining one specific case. Most people are not going to notice anyway, or will say that the measurement is corrupt. Improving the explanation of the diagnostics that people should be doing in all existing tutorials would probably have more impact. Repeating the measurement is often the easiest solution. That is also what I would have done here, had it not been for the OPM helm being stuck in the MSR. |
fine with me. I updated the file + docs already |
@tc-fieldline and @HXknappe this is a first version of the OPM coregistration tutorial, feel free to check it out |
Would it not fit better under the Source Reconstruction section in the ToC on https://www.fieldtriptoolbox.org/tutorial ? The electrode localization is also there. |
I suggest to add a section "Coregistration using a custom designed 3D helmet" and just a few sentences saying that that is possible, that such a design starts from a head surface scan and/or anatomical MRI, and that consequently the custom helmet and sensor positions are more or less automatically coregistered with tha head in the CAD design process. |
can we change |
I did not know about this I suggest to add it shortly after exercise 3 as there the plotting is done using the subset of channels that was measured and the full layout. A bit later the tutorial shifts to using nans to "pad" the data with channels that were not recorded. |
should we use
or a better controlled call to |
in the following section I wonder whether the headshape is needed:
note that this way of calling ft_prepare_sourcemodel makes an implicit selection of the method, I suggest to specify explicitly
does |
the tutorial could use a "The dataset used in this tutorial" section under "Background". That is something I have been adding to more tutorials recently, as sometimes it is quite hard to find out where to download data; and we DO want people to download the data and try it out themselves, not just read the website. |
The "See also" section has no other links. |
Hehe, indeed. I copied this over from the preprocessing_opm tutorial (which also doesn't have links). I'd be happy to remove it for now (and try to remember until there will be documentation that needs to be linked). |
I'd be happy to add a little blurb, but I got the impression from an earlier discussion with you that the exact data that will be hosted here is still a bit of a moving target. If it's not to be updated anytime soon, I can add a few words. |
I kind of expected the inside to be bounded in a single call to ft_prepare_sourcemodel, but the current version of the code did not produce the desired effect. I could fix it in the code, because I agree that this is a realistic expectation (and in my memory this used to work). |
Ah, there are no example or FAQ pages tagged with OPM, hence there is nothing listed. I suggest to make that (on both pages) a list of all pages tagged with OPM; that list is not too long. |
hehe, error here. Do you mean to add the links manually, because the parsing of the tag opm doesn't work well? |
I just created a PR for this on the fieldtrip repo |
can you add the "see also" just with the single tag "opm" like explained here? When using two tags, it will combine them as AND, so "opm" AND "example", which returns an empty list. |
* WIP - started a page (currently unlinked) for opm coregistration
No description provided.