Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardware wallet operations #339

Open
wants to merge 878 commits into
base: next
Choose a base branch
from
Open

hardware wallet operations #339

wants to merge 878 commits into from

Conversation

stdevAlDen
Copy link

@stdevAlDen stdevAlDen commented Feb 11, 2020 •
edited
Loading

Fixes #255

Changes:

  • Remove skycon git submodule, use it as vendor
  • Run skywallet-mcu emulator on travis(share network with docker)
  • Change skywallet signer implementation to a promise schema

Does this change need to mentioned in CHANGELOG.md?
yes

Requires testing
yes

stdevMac and others added 30 commits January 26, 2020 17:08
@stdevMac
Merge remote-tracking branch 'remotes/origin/develop' into stdevMac_t…
45b6dbd 
…295_slow_load_times

# Conflicts:
#	src/ui/Settings.qml
@stdevMac
[log] refs fibercrypto#295 Add debugging comments
8216043
@AntiD2ta
[ui] refs fibercrypto#318 - Remove some duplicated and useless alias.…
dd78987 
… Add some logs
@AntiD2ta
[logging] refs fibercrypto#318 - Add function LevelFromEnum. Add enum…
707401f 
… for log level

This function returns a logrus.level from an enum identifier.
@AntiD2ta
[config] refs fibercrypto#318 - Change LevelFromString call for Level…
ab0e150 
…FromEnum
@stdevMac
Merge branch 'stdevMac_t295_slow_load_times' into stdevAntiD2ta_t295_…
43f5df8 
…Slow_load_times

# Conflicts:
#	src/coin/skycoin/config/config.go
#	src/main/config.go
#	src/models/history/historyManager.go
#	src/models/walletsManager.go
#	src/ui/Settings.qml
@stdevCrow
Remove duplicated aliases
f3362d7
@stdevMac
[addresses] refs fibercrypto#295 Remove unused update
223b7fb
@stdevMac
Merge remote-tracking branch 'simelo/stdevAntiD2ta_t295_Slow_load_tim…
3075bc6 
…es' into stdevAntiD2ta_t295_Slow_load_times
@stdevMac
refs fibercrypto#295 Remove unused code
80f8208
@stdevMac
[wallets] refs fibercrypto#295 Remove wallet iterator
8c9bbce
@stdevMac
[qml] refs fibercrypto#295 Remove qml comments
8b424f5
@stdevMac
[qml][history] refs fibercrypto#295 set qml ownership to addressList …
6fd3959 
…in history
@stdevMac
[qml] refs fibercrypto#295 Remove promise from outputs
f1ecf61
refactor, improve promise chaining in snifHw ref fibercrypto#255
bb58f01
fix bip39 word request layout ref fibercrypto#255
b953afd
@olemis
Merge remote-tracking branch 'simelo_alt/stdevRulo_t279_improve_cover…
8b89c40 
…age' into stdevRulo_t279_improve_coverage
@stdevCrow
Merge branch 'stdevAntiD2ta_t298_Log_events_to_file' of https://githu…
b7bf8e3 
…b.com/simelo/FiberCryptoWallet into stdevCrow_Add_Options_for_the_Log_in_Settings
@stdevCrow
Merge branch 'stdevCrow_Add_Options_for_the_Log_in_Settings' of https…
a041a6b 
…://github.com/simelo/FiberCryptoWallet into stdevCrow_Improve_AddressBook_Layout_Settings
@stdevCrow
Call updateFooterButtonStatus appropriatelly
8058343 
Remove all `console.log`
@mauricio1802
[models] Fix history filters for load async and update addresses and …
c150d26 
…wallets kepping state of marked filters
@mauricio1802
[models] Fix historyManager.getTransactions and historyManager.getTra…
8c7557e 
…nsactionsWithFilters
@mauricio1802
[models] Fix historyManager.getTransactions method, was returning dup…
8c269d1 
…licated transactions
@mauricio1802
[ui][history] Fix behaviour of check boxes in filters of history page
2fa4777
@stdevMac
[walletManager] refs fibercrypto#295 Add created wallets to wallets list
b317ef3
@stdevMac
[wallets] refs fibercrypto#295 Update wallets list in send page every…
40e37b0 
… click
@mauricio1802
[model] Fix GetNewTransactions and GetNewTransactionsWithFilters meth…
0060a97 
…ods for don't return duplicated transacions
@stdevCrow
Improve visual layout
a02f067
@stdevCrow
Refactorize the code by adding a signal toggleEncryptionRequested t…
1e48c40 
…o manage the encryption outside the delegate

Remove unused code and useless comments
@stdevCrow
Remove an unneccesary DialogGetPassword by move the specific proper…
ccaaae4 
…ties to the previosly existing dialog

Handle the encryption from here
Improve visual layout of dialogs
olemis and others added 20 commits March 3, 2020 18:37
@olemis
[errors] refs fibercrypto#139 - Fix ErrNotImplemented redeclared
4916a2a
@olemis
[sky] refs fibercrypto#139 - Adjust test comparing params.DataRefresh…
40513b2 
…Timeout vs SkycoinBlockchain.CacheTime
@olemis
[sky] refs fibercrypto#139 - Correct comparison between params.DataRe…
cd674d6 
…freshTimeout and SkycoinBlockchain.CacheTime
@olemis
[ci] refs fibercrypto#139 - Remove duplicate declaration of make test…
f405a23 
…-skyhw target
@olemis
[ci] refs fibercrypto#139 - Increase Skycoin test suite timeout
3c19cd9
@olemis
[ci] refs fibercrypto#139 - Do not make build prior to make test-skyhw
d52aef3
@olemis
[contrib] [models] refs fibercrypto#139 - Handle errors after changin…
6e9010a 
…g signature of GetSpentOutput and GetAddress

... still WiP
improve error handling in derivationType determination ref fibercrypt…
7dcd440 
…o#139
fix mocks generation rule ref fibercrypto#139
7005f40
fix number scale in tests ref fibercrypto#139
e51a14f
fix rawTxn2Transaction, handle errors ref fibercrypto#139
650034d
Merge branch 'stdevAlDen_t139_hardware_wallet_signer' into stdevAlDen…
b62b88f 
…_t255_hardware_wallet_operations

Conflicts:
	Gopkg.lock
	Makefile
	src/contrib/hardware-wallet/skywallet/sky-wallet.go
	src/models/walletsModel.go
ref fibercrypto#255
@olemis
Merge pull request fibercrypto#253 from simelo/stdevAlDen_t139_hardwa…
44dd804 
…re_wallet_signer

Hardware wallet signer fixes fibercrypto#139
@mauricio1802
Update history UI after every new transaction
e85bc03
update vendors ref fibercrypto#255
45b040c
fix tests (stubs) to work with new API ref fibercrypto#255
6468e50
@mauricio1802
Add oredered addresses to wallet manager i order to keep order for ad…
339a1bf 
…dresses in UI
be able to ClearSingleTimeOperationsCache ref fibercrypto#255
eb0eb30
fix snifHw registration ref fibercrypto#255
d53df3f
ClearSingleTimeOperationsCache on device disconnected ref fibercrypto…
9b54a17 
…#255
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t255_hardware_wallet_operations branch from 5b494e0 to 9b54a17 Compare March 7, 2020 01:05
stdevMac and others added 4 commits March 8, 2020 16:43
@stdevMac
Merge pull request fibercrypto#349 from simelo/stdevMauricio1802_t347…
c651489 
…_History_async_update_not_accurate

Update history UI after every new transaction
@stdevMac
Merge pull request fibercrypto#350 from simelo/stdevMauricio1802_t348…
92d6b1c 
…_Match_addresses_order_with_deterministic_sequence

Add order to addresses list
fix error checking in walletManager signTxn ref fibercrypto#353
3224ab0
remove PersistibleSet ref fibercrypto#353
1051dfe
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t255_hardware_wallet_operations branch 3 times, most recently from 256c05a to bc2f544 Compare March 10, 2020 14:34
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t255_hardware_wallet_operations branch from bc2f544 to 7ff01cc Compare March 10, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis Awaiting requested review from olemis

Assignees

@stdevAlDen stdevAlDen

Labels
wallet-hw Hardware wallet integration wip Work in progress
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
7 participants
@stdevAlDen @stdevMac @AntiD2ta @stdevCrow @olemis @mauricio1802 @hsequeda