feat(quote): add more validations #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
changed the title
cajubelt
reviewed
Aug 25, 2023
src/mock-data/quote.ts
Outdated
| cryptoType: CryptoType.cUSD, | ||
| fiatType: FiatType.NGN, | ||
| cryptoAmount: '10', | ||
| fiatAmount: '7560', |
There was a problem hiding this comment.
for some providers, 10 is at or near the minimum quote offered. Given that Naira can fluctuate in value, we might want to increase cryptoAmount too so there's more of a buffer. Otherwise if Naira decreased in value, this could drop below the minimum quote amount offered by the provider, assuming that minimum amount is denominated in dollars
There was a problem hiding this comment.
same with the other mock quotes for 10 cUSD that now have a fiat amount
There was a problem hiding this comment.
I updated all quotes to be 20 cUSD, and also dropped the in / out in the field names since some objects were just duplicates
jh2oman
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for requests missing required fields, checking if quote can be fetched with either amount