Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maximum between liveness and readiness for fail_time #196

Closed
wants to merge 2 commits into from
Closed

Use maximum between liveness and readiness for fail_time #196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0eef7
Use maximum between liveness and readiness for fail_time
Nov 15, 2022
25e376c
Use max instead of if
Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fiaas_deploy_daemon/deployer/kubernetes/ready_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ def __init__(self, app_spec, bookkeeper, lifecycle, lifecycle_subject, ingress_a
self._bookkeeper = bookkeeper
self._lifecycle = lifecycle
self._lifecycle_subject = lifecycle_subject
readiness_delay = app_spec.health_checks.readiness.initial_delay_seconds
liveness_delay = app_spec.health_checks.liveness.initial_delay_seconds
self._fail_after_seconds = _calculate_fail_time(
config.ready_check_timeout_multiplier,
app_spec.autoscaler.max_replicas,
app_spec.health_checks.readiness.initial_delay_seconds
readiness_delay if readiness_delay > liveness_delay else liveness_delay
herodes1991 marked this conversation as resolved.
Show resolved Hide resolved
)
self._fail_after = time_monotonic() + self._fail_after_seconds
self._should_check_ingress = config.tls_certificate_ready
Expand Down