change browse file/directory icon from SP_FileDialogStart to semantic…

…ally correct SP_DialogOpenButton
fhomolka · Aug 21, 2023 · 22f0172 · 22f0172
1 parent b608dc9
commit 22f0172
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/contrib/prtview/LoadPortalFileDialog.cpp b/contrib/prtview/LoadPortalFileDialog.cpp
@@ -52,7 +52,7 @@ bool DoLoadPortalFileDialog(){
 		auto vbox = new QVBoxLayout( &dialog );
 		{
 			vbox->addWidget( line = new QLineEdit );
-			auto button = line->addAction( QApplication::style()->standardIcon( QStyle::SP_FileDialogStart ), QLineEdit::ActionPosition::TrailingPosition );
+			auto button = line->addAction( QApplication::style()->standardIcon( QStyle::SP_DialogOpenButton ), QLineEdit::ActionPosition::TrailingPosition );
 			QObject::connect( button, &QAction::triggered, [line](){
 				if ( const char* filename = GlobalRadiant().m_pfnFileDialog( g_pRadiantWnd, true, "Locate portal (.prt) file", line->text().toLatin1().constData(), 0, true, false, false ) )
 					line->setText( filename );

diff --git a/libs/gtkutil/dialog.cpp b/libs/gtkutil/dialog.cpp
@@ -49,7 +49,7 @@ RadioHBox RadioHBox_new( StringArrayRange names ){
 
 PathEntry PathEntry_new(){
 	auto entry = new QLineEdit;
-	auto button = entry->addAction( QApplication::style()->standardIcon( QStyle::SP_FileDialogStart ), QLineEdit::ActionPosition::TrailingPosition );
+	auto button = entry->addAction( QApplication::style()->standardIcon( QStyle::SP_DialogOpenButton ), QLineEdit::ActionPosition::TrailingPosition );
 	return PathEntry( entry, button );
 }
 

diff --git a/radiant/entityinspector.cpp b/radiant/entityinspector.cpp
@@ -247,7 +247,7 @@ class ModelAttribute final : public EntityAttribute
 	ModelAttribute( const char* key ) :
 		m_key( key ),
 		m_entry( new NonModalEntry( ApplyCaller( *this ), UpdateCaller( *this ) ) ){
-		auto button = m_entry->addAction( QApplication::style()->standardIcon( QStyle::SP_FileDialogStart ), QLineEdit::ActionPosition::TrailingPosition );
+		auto button = m_entry->addAction( QApplication::style()->standardIcon( QStyle::SP_DialogOpenButton ), QLineEdit::ActionPosition::TrailingPosition );
 		QObject::connect( button, &QAction::triggered, [this](){ browse(); } );
 	}
 	void release() override {