Fhir server integration and patient searching/opening #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wmaethner
commented
Aug 19, 2018
•
wmaethner
commented
- Added configurable FHIR server support
- Can search for patients on that FHIR server by ID or name
- The search displays a list of results which can be selected and opened
- The open patient's info is then displayed
- Updated the UI as well
Initial FHIR server integration. Uses a default hardcoded FHIR server and can search a patient and study on that server.
Added configurable FHIR server support and patient searching given an ID or name.
lbergnehr
requested changes
Sep 10, 2018
Common/Common.csproj
Outdated
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.1.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Reference Include="Microsoft.AspNetCore.Mvc.ViewFeatures"> | ||
| <HintPath>..\..\..\..\..\..\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.aspnetcore.mvc.viewfeatures\2.1.1\lib\netstandard2.0\Microsoft.AspNetCore.Mvc.ViewFeatures.dll</HintPath> |
There was a problem hiding this comment.
I don't think this will build as it's an absolute reference on your computer. Could you add that reference as a NuGet package instead? Like what you're doing on line 8 above.
|
Fixed that issue @lbergnehr, it passed the Travis build so should be good now. |
lbergnehr
reviewed
Sep 30, 2018
There was a problem hiding this comment.
Sorry for the late review! I don't think we should have things stuck in review if they can be of use in the field. Let's fix things as they come up instead; but here are a few things that I came across:
- Using bootstrap from a cdn will effectively require you to have internet access when developing on this.
- Some
camelCasewhere it should bePascalCase. - Formatting (which we haven't set) with braces on the next line, whereas the history of the code so far has been mainly braces on the same line as the method (or whatever construct).
- The static model (
internalModel) will be a world of hurt for me, or us, when merging the signalr branch since that kind of challenges that model completely.
Great work with fetching the data from a FHIR server! Will sure come in handy when using this cross vendors with different data sets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.