pull new file and replace old name #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Trying to address Issue #87, specifically that the slido export files seem to be named Polls-per-participant- now and so my latest refresh data didn't have access to some data I expected to have. This change pulls those new files, and renames the old ones to match the new ones.
What was your approach?
Polls-per-participantto theslido_tagsvector (following the pattern of the other tags)slido_typevector, usinggsubto replacePolls-per-userwithPolls-per-participantWhat GitHub issue does your pull request address?
Issue #87
How were the changes tested?
I followed as much of the script locally as I could and visually inspecting the
slido_filesdf, I can see that the file name column has the original Polls-per-user in the name, but the slido_type column Polls-per-user's have been replaced with Polls-per-participant. I also see that the Polls-per-participant files are in the dataframe this time.Tell potential reviewers what kind of feedback you are soliciting.
@cansavvy is this the fix you were envisioning?