Updating google analytics metrics getter #73
Conversation
|
I also ran I can separate out these changes if it makes it to hard to review, but I tried to highlight the actual changes. |
| @@ -127,6 +127,41 @@ get_ga_properties <- function(account_id, token = NULL) { | |||
| return(results$properties) | |||
| } | |||
|
|
|||
| #' Get all property information for a particular property id | |||
There was a problem hiding this comment.
@howardbaek This is a new function
There was a problem hiding this comment.
This isn't working for me. As documented, I made sure to check the box See and download your Google Analytics data. on the OAuth screen:
When I run the example, I get
> property_info <- get_ga_property_info(property_id = "422558989")
Using user-supplied cached tokens stored using authorize("google")
Error in request_ga(token = token, url = paste0("https://analyticsadmin.googleapis.com/v1alpha/properties/", :
API request failed:{
"error": {
"code": 403,
"message": "The caller does not have permission",
"status": "PERMISSION_DENIED"
}
}
There was a problem hiding this comment.
@howardbaek Did you login with ITCR Gmail or your own personal gmail? If you logged in with your own gmail, you don't have access to this property id so it wouldn't work.
There was a problem hiding this comment.
I should make that more clear in the example
| #' } | ||
| get_all_ga_metrics <- function(account_id = NULL, token = NULL, dataformat = "dataframe") { | ||
| get_multiple_ga_metrics <- function(account_id = NULL, property_ids = NULL, token = NULL, dataformat = "dataframe", |
There was a problem hiding this comment.
And this function got reworked. Can you take a look and see what you think of the changes and if you have recommendations? @howardbaek
There was a problem hiding this comment.
Same as above:
> some_properties <- get_multiple_ga_metrics(property_ids = c("422671031", "422558989"))
Using user-supplied cached tokens stored using authorize("google")
Error in request_ga(token = token, url = paste0("https://analyticsadmin.googleapis.com/v1alpha/properties/", :
API request failed:{
"error": {
"code": 403,
"message": "The caller does not have permission",
"status": "PERMISSION_DENIED"
}
}
|
We tested this in a pair programming session and found out it was because Howard was trying to access a property id with the hutchgmail account that it does not have access to. Tried to fix the docs appropriately. |
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Fixing up some things for usability and DRYness purposes.
The google analytics
all_ga_metrics()is being deprecated changed so it can take property ids instead of just taking all properties from an account.In order to do this, we needed to make a new function
get_ga_property_info()that will allow a display name (and other info) for a property to be retrieved.