Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for credentials first before going through auth process #61

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Covering #48 from @howardbaek

This makes it so we check for creds first and ask the user if we want to replace the creds or move on.

Copy link
Contributor

@howardbaik howardbaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a couple of changes to user-facing messages, like capitalizing the app names and improving syntax for the Yes/No messages.

@cansavvy
Copy link
Collaborator Author

Awesome! Thanks!

@cansavvy cansavvy merged commit 3ad2b12 into main Jan 24, 2024
6 checks passed
@cansavvy cansavvy deleted the cansavvy/check-tokens branch January 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants