Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows builds with assembly optimisations enabled to CI #64

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

frankplow
Copy link
Collaborator

This PR adds two new jobs to CI for building and testing with assembly optimisations enabled and assembled with NASM and YASM on Windows.

Different operating systems are now combined into a single matrix as this is easier to manage with all the combinations of OS/compiler/assembler. I think this will also be more future-proof as different checks and combinations are added. This required using MSYS/MSVC instead of FFVS-Project-Generator. If we still want to check FFVS-Project-Generator can generate a valid VS solution in CI I can add this as a separate job.

The new jobs have flagged an error when compiling with YASM.

@frankplow
Copy link
Collaborator Author

test / windows/msvc/none failure and test / windows/msvc/nasm failure are related to #26 I believe.

@nuomi2021
Copy link
Member

The new jobs have flagged an [error when compiling with YASM]

thank you for the pr,it has avx512 :) https://github.com/ffvvc/FFmpeg/actions/runs/4711935904/jobs/8356796175?pr=65#step:6:72
yasm issue fixed by fixed by #65

If we still want to check FFVS-Project-Generator can generate a valid VS solution in CI I can add this as a separate job.

Not needed since you already use cl.exe to compile.

@nuomi2021
Copy link
Member

how about we change none to c_only or no_asm. none can mean many things, we may forget the mean in the short time.

@frankplow
Copy link
Collaborator Author

frankplow commented Apr 17, 2023

Histories are behaving a little strangely because #65 was branched from frankplow:ci-enhancements but merged into FFmpeg:main before this PR - any chance this can be merged?

@frankplow frankplow mentioned this pull request Apr 24, 2023
@frankplow
Copy link
Collaborator Author

Rebased onto main

@nuomi2021 nuomi2021 merged commit 390148b into ffvvc:main Apr 24, 2023
@frankplow frankplow deleted the ci-enhancements branch April 24, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants