Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify H2656_CHROMA_DEBLOCK #272

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

nuomi2021
Copy link
Member

No description provided.

@nuomi2021 nuomi2021 changed the title simplfy H2656_CHROMA_DEBLOCK simplify H2656_CHROMA_DEBLOCK Nov 23, 2024
@nuomi2021 nuomi2021 force-pushed the H2656_CHROMA_DEBLOCK branch from 958ff70 to 131bd22 Compare November 24, 2024 13:43
@nuomi2021
Copy link
Member Author

@stone-d-chen , The one-sided check asm test might not be functional. If I disable this line
line https://github.com/ffvvc/FFmpeg/pull/272/files#diff-519e64dabcabdb9e30163dbbd4c91c2037fea9304dcbc2da1313fc6044c4f1c4R326 , the vvc_deblock test still passed

@stone-d-chen
Copy link
Collaborator

@stone-d-chen , The one-sided check asm test might not be functional. If I disable this line line https://github.com/ffvvc/FFmpeg/pull/272/files#diff-519e64dabcabdb9e30163dbbd4c91c2037fea9304dcbc2da1313fc6044c4f1c4R326 , the vvc_deblock test still passed

You're right, submitted a PR for the bug fix #273

Additionally there seems like there's a bug in the vertical one-sided implementation I'll need to fix.

@nuomi2021 nuomi2021 merged commit df189b9 into ffvvc:deblock_asm Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants