Fix some old comments #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2024
nuomi2021
reviewed
Jul 22, 2024
| @@ -904,7 +878,7 @@ static int inline vvc_get_cabac(CABACContext *c, VVCCabacState* base, const int | |||
| c->low <<= lps_mask; | |||
|
|
|||
| if (!(c->low & CABAC_MASK)) | |||
| vvc_refill2(c); | |||
There was a problem hiding this comment.
I remember this will introduce some build errors for the window
could you "git cherry-pick ..ffvvc/workflow" and force-push your branch?
So we can now see the windows result
There was a problem hiding this comment.
For sure, I also tried it on Windows and everything works
There was a problem hiding this comment.
Great! please send to maling list for review.
thank you
From Jun Zhao <[email protected]>: > Should we relocate this to the decoder? Other codecs typically set this > parameter in the decoder. Signed-off-by: Wu Jianhua <[email protected]>
See ffvvc#178 Signed-off-by: Wu Jianhua <[email protected]>
See ffvvc#180 Signed-off-by: Wu Jianhua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.