fix: Don't include unminified p5 lib into build #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for p5-codesandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying p5-code-sandbox with
|
| Latest commit: |
3b240f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49518c2f.p5-code-sandbox.pages.dev |
| Branch Preview URL: | https://fix-workbox.p5-code-sandbox.pages.dev |
public folder was still cached by workbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Copilot Summary]
This pull request includes several changes aimed at optimizing the way the
p5.jslibrary is handled in the project. The main updates involve switching from the fullp5.jsfile to the minified version, updating the build and copy scripts, and ensuring consistency across the codebase.Optimizing
p5.jsHandling:astro.config.mjs: Commented out the inclusion of the fullp5.jsfile and retained the minified version (p5.min.js) for better performance.package.json: Updated thecopy:p5script to use a newcopy-p5.mjsscript for copying the necessaryp5files, ensuring the minified versions are used.scripts/copy-p5.mjs: Added a new script to copy the minifiedp5files fromnode_modulesto thepublicdirectory.Code Consistency:
src/lib/iframe-source.ts: Updated the script source in theiframeSourcefunction to usep5.min.jsinstead of the fullp5.jsfile.test/iframe-source.test.ts: Modified the test to check forp5.min.jsinstead ofp5.jsto match the updated script source.