Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(example): remove examples from this repo (moved to new repo) #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(example): remove examples from this repo (moved to new repo) #565

wants to merge 1 commit into from

Conversation

5A11
Copy link
Member

@5A11 5A11 commented Oct 21, 2024

Proposed Changes

Remove the examples from this repo (all are moved here).

This PR should now be closed.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

5A11
5A11 commented Oct 21, 2024
View reviewed changes
python/docs/booking-demo.md
@@ -32,7 +32,7 @@ restaurant = Agent(

fund_agent_if_low(restaurant.wallet.address())
```
The protocols `query_proto` and `book_proto` are built from message handlers in the same way as agents. See [query protocol](https://github.com/fetchai/uAgents/blob/main/python/examples/09-booking-protocol-demo/protocols/query.py) and [book protocol](https://github.com/fetchai/uAgents/blob/main/python/examples/09-booking-protocol-demo/protocols/book.py) for the details and logic behind these protocols, but for now we will simply import them. You will need to add these files inside a `protocols` folder in the same directory you are running your agent. See [agent protocols](agent-protocols.md) for more information.
The protocols `query_proto` and `book_proto` are built from message handlers in the same way as agents. You will need to add these files inside a `protocols` folder in the same directory you are running your agent. See [agent protocols](agent-protocols.md) for more information.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 09-booking-protocol-demo wasn't in the planned overhaul of the examples and so was not moved into the Examples repo.

I suggest we refactor this doc to either refer to another example or add this example back in the new repo and replace the links.

Same below.

@5A11 5A11 changed the title refactor: remove examples from this repo (moved to new repo) refactor(example): remove examples from this repo (moved to new repo) Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjsc devjsc Awaiting requested review from devjsc devjsc is a code owner

@jrriehl jrriehl Awaiting requested review from jrriehl jrriehl is a code owner

@Archento Archento Awaiting requested review from Archento Archento is a code owner

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@5A11