pre-release: ASI upgrade #392
Conversation
MissingNO57
changed the title
|
Visit the preview URL for this PR (updated for commit 2b8f849): https://fetch-docs-preview--pr392-feat-asi-upgrade-con-pyqiamkm.web.app (expires Thu, 20 Jun 2024 10:08:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2de39fd4e81249941960b74fbab0a62d90d69f8 |
| @@ -177,12 +177,12 @@ class TestContractRestAPI(TestContract): | |||
|
|
|||
| def _get_network_config(self): | |||
There was a problem hiding this comment.
In some integration tests we deploy sample contracts on testnet in every run! This leads to adding unnecessary data there.
There was a problem hiding this comment.
It would be nice to add better support for simulating txs for tests like these, because I think in almost all cases, that is all that really needs to be tested.
MissingNO57
changed the title
MissingNO57
changed the title
| @@ -125,8 +140,8 @@ def fetchai_mainnet(cls) -> "NetworkConfig": | |||
| chain_id="fetchhub-4", | |||
| url="grpc+https://grpc-fetchhub.fetch.ai", | |||
| fee_minimum_gas_price=0, | |||
There was a problem hiding this comment.
Note: We have been considering setting this default minimum gas price here to non-zero value (the same value as for testnet). Even though this is not enforceable, practically speaking, this is what we want - if nothing else, then at least defaulting to non-zero Tx gas price value will make it less straightforward for users to use zero Tx fee.
There was a problem hiding this comment.
For now (for ASI umgrade release), please ignore my comment above. We will touch on thsese kind of things in later releases.
There was a problem hiding this comment.
Note: In this sense (= not now), we shall also extend the NetworkConfig class with address prefix data member.
pbukva
changed the title
Proposed changes
asifetchaddresses toasiaddresses in examples, tests, and docs.Do we know new chain-id for
fetchhub-4?Issues
Links to any issues resolved.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.mainbranch.If applicable
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.