Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of tmap_1db #75

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

rekomodo
Copy link
Collaborator

Contributes to #33 .

Copy link
Contributor

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rekomodo I did some changes to improve the performance:

  • reduced the size of the problem
  • only have a small stepsize around the breakthrough time
  • optimised mesh

The trapped concentration gradients are extremely steep. And this produces oscillations:

image

This is something you often see with this case and is called Gibbs phenomenon. Refining the mesh helps, sometimes using DG elements for traps helps too (but here it seems to be making things worse).

This is why you have this little wave on the rise of the flux curve. I don't really know how to get rid of this tbf

image

report/verification/mes/tmap_1db.md Outdated Show resolved Hide resolved
report/verification/mes/tmap_1db.md Outdated Show resolved Hide resolved
report/verification/mes/tmap_1db.md Outdated Show resolved Hide resolved
report/verification/mes/tmap_1db.md Outdated Show resolved Hide resolved
report/verification/mes/tmap_1db.md Show resolved Hide resolved
report/verification/mes/tmap_1db.md Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin merged commit c51abb8 into festim-dev:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants