TXTExport refactoring

docs/source/api/exports.rst

@@ -15,10 +15,6 @@ Exports
     :members:
     :show-inheritance:
 
-.. autoclass:: TXTExports
-    :members:
-    :show-inheritance:
-
 .. autoclass:: TrapDensityXDMF
     :members:
     :show-inheritance:

festim/__init__.py

@@ -88,7 +88,7 @@
 
 from .exports.derived_quantities.derived_quantities import DerivedQuantities
 
-from .exports.txt_export import TXTExport, TXTExports
+from .exports.txt_export import TXTExport
 
 
 from .settings import Settings

festim/exports/exports.py

@@ -129,8 +129,7 @@ def write(self, label_to_function, dx):
                         label_to_function[export.field], self.V_DG1
                     )
                 export.function = label_to_function[export.field]
-                steady = self.final_time == None
-                export.write(self.t, steady)
+                export.write(self.t, self.final_time)
         self.nb_iterations += 1
 
     def initialise_derived_quantities(self, dx, ds, materials):

festim/exports/txt_export.py

@@ -13,22 +13,40 @@ class TXTExport(festim.Export):
         field (str): the exported field ("solute", "1", "retention",
             "T"...)
         filename (str): the filename (must end with .txt).
+        write_at_last (bool): if True, the data will be exported at
+            the last export time. Otherwise, the data will be exported
+            at each export time. Defaults to False.
         times (list, optional): if provided, the field will be
             exported at these timesteps. Otherwise exports at all
             timesteps. Defaults to None.
         header_format (str, optional): the format of column headers.
             Defautls to ".2e".
+
+    Attributes:
+        data (np.array): the data array of the exported field. The first column
+            is the mesh vertices. Each next column is the field profile at the specific
+            export time.
+        header (str): the header of the exported file.
+        V (fenics.FunctionSpace): the vector-function space for the exported field.
+
     """
 
-    def __init__(self, field, filename, times=None, header_format=".2e") -> None:
+    def __init__(
+        self, field, filename, times=None, write_at_last=False, header_format=".2e"
+    ) -> None:
         super().__init__(field=field)
         if times:
             self.times = sorted(times)
         else:
             self.times = times
         self.filename = filename
+        self.write_at_last = write_at_last
         self.header_format = header_format
-        self._first_time = True
+
+        self.data = None
+        self.header = None
+        self.V = None
+        self._unique_indices = None
 
     @property
     def filename(self):
@@ -44,90 +62,157 @@ def filename(self, value):
         self._filename = value
 
     def is_it_time_to_export(self, current_time):
+        """
+        Checks if the exported field should be written to a file or not
+        based on the current time and the TXTExport.times
+
+        Args:
+            current_time (float): the current simulation time
+
+        Returns:
+            bool: True if the exported field should be written to a file, else False
+        """
+
         if self.times is None:
             return True
         for time in self.times:
             if np.isclose(time, current_time, atol=0):
                 return True
         return False
 
-    def when_is_next_time(self, current_time):
-        if self.times is None:
-            return None
-        for time in self.times:
-            if current_time < time:
-                return time
-        return None
+    def is_last(self, current_time, final_time):
+        """
+        Checks if the current simulation step equals to the last export time.
+        based on the final simulation time, TXTExport.times, and the current time
+
+        Args:
+            current_time (float): the current simulation time.
+            final_time (float, None): the final simulation time.
+
+        Returns:
+            bool: True if simulation is steady (final_time is None), if TXTExport.times
+                are not provided and the current time equals to the final time, or if
+                TXTExport.times are provided and the current time equals to the last time in
+                TXTExport.times, else False.
+        """
+
+        if final_time is None:
+            # write if steady
+            return True
+        elif self.times is None:
+            if np.isclose(current_time, final_time, atol=0):
+                # write at final time if exports at each timestep
+                return True
+        else:
+            if np.isclose(current_time, self.times[-1], atol=0):
+                # write at final time if exports at specific times
+                return True
+        return False
+
+    def initialise(self, mesh, project_to_DG=False, materials=None):
+        """
+        Initialises TXTExport. Depending on the project_to_DG flag, defines a function space (DG1 or CG1)
+        for projection of the exported field. After that, an unsorted array of mesh vertices is created for export.
+        The array is then used to obtain indices of sorted elements for the data export.
+
+        .. note::
+            If DG1 is used, the duplicated vertices in the array are filtered except those near interfaces,
+            The interfaces are defined by ``material.borders`` in the ``Materials`` list.
+
+        Args:
+            mesh (fenics.Mesh): the mesh.
+            project_to_DG (bool): if True, the exported field is projected to a DG1 function space.
+                Defaults to False.
+            materials (festim.Materials): the materials. Defaults to None.
+        """
+
+        if project_to_DG:
+            self.V = f.FunctionSpace(mesh, "DG", 1)
+        else:
+            self.V = f.FunctionSpace(mesh, "CG", 1)
+
+        x = f.interpolate(f.Expression("x[0]", degree=1), self.V)
+        x_column = np.transpose([x.vector()[:]])
+
+        # if project_to_DG is True, get indices of duplicates near interfaces
+        # and indices of the first elements from a pair of duplicates otherwise
+        if project_to_DG:
+            # Collect all borders
+            borders = []
+            for material in materials:
+                if material.borders:
+                    for border in material.borders:
+                        borders.append(border)
+            borders = np.unique(borders)
+
+            # Find indices of the closest duplicates to interfaces
+            border_indices = []
+            for border in borders:
+                closest_indx = np.abs(x_column - border).argmin()
+                closest_x = x_column[closest_indx]
+                for ind in np.where(x_column == closest_x)[0]:
+                    border_indices.append(ind)
+
+            # Find indices of first elements in duplicated pairs and mesh borders
+            _, mesh_indices = np.unique(x_column, return_index=True)
+
+            # Get unique indices from both arrays preserving the order in unsorted x-array
+            unique_indices = []
+            for indx in np.argsort(x_column, axis=0)[:, 0]:
+                if (indx in mesh_indices) or (indx in border_indices):
+                    unique_indices.append(indx)
+
+            self._unique_indices = np.array(unique_indices)
+
+        else:
+            # Get list of unique indices
+            self._unique_indices = np.argsort(x_column, axis=0)[:, 0]
 
-    def write(self, current_time, steady):
-        # create a DG1 functionspace
-        V_DG1 = f.FunctionSpace(self.function.function_space().mesh(), "DG", 1)
+        self.data = x_column[self._unique_indices]
+        self.header = "x"
+
+    def write(self, current_time, final_time):
+        """
+        Modifies the header and writes the data to a file depending on
+        the current and the final times of a simulation.
+
+        Args:
+            current_time (float): the current simulation time.
+            final_time (float, None): the final simulation time.
+        """
 
-        solution = f.project(self.function, V_DG1)
-        solution_column = np.transpose(solution.vector()[:])
         if self.is_it_time_to_export(current_time):
+            solution = f.project(self.function, self.V)
+            solution_column = np.transpose(solution.vector()[:])
+
             # if the directory doesn't exist
             # create it
             dirname = os.path.dirname(self.filename)
             if not os.path.exists(dirname):
                 os.makedirs(dirname, exist_ok=True)
 
-            # if steady or it is the first time to export
-            # write data
-            # else append new column to the existing file
-            if steady or self._first_time:
-                if steady:
-                    header = "x,t=steady"
-                else:
-                    header = f"x,t={format(current_time, self.header_format)}s"
-                x = f.interpolate(f.Expression("x[0]", degree=1), V_DG1)
-                x_column = np.transpose([x.vector()[:]])
-                data = np.column_stack([x_column, solution_column])
-                self._first_time = False
+            # if steady, add the corresponding label
+            # else append new export time to the header
+            steady = final_time is None
+            if steady:
+                self.header += ",t=steady"
             else:
-                # Update the header
-                old_file = open(self.filename)
-                old_header = old_file.readline().split("\n")[0]
-                old_file.close()
-                header = old_header + f",t={format(current_time, self.header_format)}s"
-                # Append new column
-                old_columns = np.loadtxt(self.filename, delimiter=",", skiprows=1)
-                data = np.column_stack([old_columns, solution_column])
-
-            np.savetxt(self.filename, data, header=header, delimiter=",", comments="")
-
-
-class TXTExports:
-    """
-    Args:
-        fields (list): list of exported fields ("solute", "1", "retention",
-            "T"...)
-        filenames (list): list of the filenames for each field (must end with .txt).
-        times (list, optional): if provided, fields will be
-            exported at these timesteps. Otherwise exports at all
-            timesteps. Defaults to None.
-        header_format (str, optional): the format of column headers.
-            Defautls to ".2e".
-    """
+                self.header += f",t={format(current_time, self.header_format)}s"
 
-    def __init__(
-        self, fields=[], filenames=[], times=None, header_format=".2e"
-    ) -> None:
-        msg = "TXTExports class will be deprecated in future versions of FESTIM"
-        warnings.warn(msg, DeprecationWarning)
-
-        self.fields = fields
-        if len(self.fields) != len(filenames):
-            raise ValueError(
-                "Number of fields to be exported "
-                "doesn't match number of filenames in txt exports"
+            # Add new column of filtered and sorted data
+            self.data = np.column_stack(
+                [self.data, solution_column[self._unique_indices]]
             )
-        if times:
-            self.times = sorted(times)
-        else:
-            self.times = times
-        self.filenames = filenames
-        self.header_format = header_format
-        self.exports = []
-        for function, filename in zip(self.fields, self.filenames):
-            self.exports.append(TXTExport(function, filename, times, header_format))
+
+            if (
+                self.write_at_last and self.is_last(current_time, final_time)
+            ) or not self.write_at_last:
+
+                # Write data
+                np.savetxt(
+                    self.filename,
+                    self.data,
+                    header=self.header,
+                    delimiter=",",
+                    comments="",
+                )

festim/generic_simulation.py

@@ -357,11 +357,11 @@ def initialise(self):
 
         self.h_transport_problem.initialise(self.mesh, self.materials, self.dt)
 
-        # raise warning if the derived quantities don't match the type of mesh
-        # eg. SurfaceFlux is used with cylindrical mesh
         for export in self.exports:
             if isinstance(export, festim.DerivedQuantities):
                 for q in export:
+                    # raise warning if the derived quantities don't match the type of mesh
+                    # eg. SurfaceFlux is used with cylindrical mesh
                     if self.mesh.type not in q.allowed_meshes:
                         warnings.warn(
                             f"{type(q)} may not work as intended for {self.mesh.type} meshes"
@@ -381,31 +381,41 @@ def initialise(self):
                                 f"SurfaceKinetics boundary condition must be defined on surface {q.surface} to export data with festim.AdsorbedHydrogen"
                             )
 
-        self.exports.initialise_derived_quantities(
-            self.mesh.dx, self.mesh.ds, self.materials
-        )
-
-        # needed to ensure that data is actually exported at TXTExport.times
-        # see issue 675
-        for export in self.exports:
-            if isinstance(export, festim.TXTExport) and export.times:
-                if not self.dt.milestones:
-                    self.dt.milestones = []
-                for time in export.times:
-                    if time not in self.dt.milestones:
-                        msg = "To ensure that TXTExport exports data at the desired times "
-                        msg += "TXTExport.times are added to milestones"
-                        warnings.warn(msg)
-                        self.dt.milestones.append(time)
-                self.dt.milestones.sort()
-
-            # set Soret to True for SurfaceFlux quantities
-            if isinstance(export, festim.DerivedQuantities):
-                for q in export:
+                    # set Soret to True for SurfaceFlux quantities
                     if isinstance(q, festim.SurfaceFlux):
                         q.soret = self.settings.soret
                         q.T = self.T.T
 
+            if isinstance(export, festim.TXTExport):
+                # pre-process data depending on the chemical potential flag, trap element type,
+                #  and material borders
+                project_to_DG = (
+                    self.settings.chemical_pot
+                    or self.settings.traps_element_type == "DG"
+                )
+                export.initialise(
+                    self.mesh.mesh,
+                    project_to_DG,
+                    self.materials,
+                )
+
+                # needed to ensure that data is actually exported at TXTExport.times
+                # see issue 675
+                if export.times:
+                    if not self.dt.milestones:
+                        self.dt.milestones = []
+                    for time in export.times:
+                        if time not in self.dt.milestones:
+                            msg = "To ensure that TXTExport exports data at the desired times "
+                            msg += "TXTExport.times are added to milestones"
+                            warnings.warn(msg)
+                            self.dt.milestones.append(time)
+                    self.dt.milestones.sort()
+
+        self.exports.initialise_derived_quantities(
+            self.mesh.dx, self.mesh.ds, self.materials
+        )
+
     def run(self, completion_tone=False):
         """Runs the model.
 
@@ -503,7 +513,10 @@ def run_post_processing(self):
         self.update_post_processing_solutions()
 
         self.exports.t = self.t
-        self.exports.write(self.label_to_function, self.mesh.dx)
+        self.exports.write(
+            self.label_to_function,
+            self.mesh.dx,
+        )
 
     def update_post_processing_solutions(self):
         """Creates the post-processing functions by splitting self.u. Projects