Wrong value for error_on_nonconvergence in NewtonSolver

[KulaginVladimir]

Proposed changes

This PR fixes the bug with default parameters of the Newton solver. Currently, a simulation won't stop if Newton solver for HeatTransferProblem/ExtrinsicTrap doesn't converge. This issue is related to the default value for the error_on_nonconvergence of Newton solvers.

Types of changes

What types of changes does your code introduce to FESTIM?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code refactoring
• Documentation Update (if none of the other choices apply)
• New tests

Checklist

• Black formatted
• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (375c7b2) to head (96d70f8).
Report is 50 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          61       61           
  Lines        2750     2750           
=======================================
  Hits         2738     2738           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RemDelaporteMathurin]

Thanks for this fix @KulaginVladimir

If the CI passes then feel free to merge this to main.