Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add University of Tsukuba on the user map #853

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

iamryo
Copy link
Contributor

@iamryo iamryo commented Aug 1, 2024

add University of Tsukuba to the map

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

add University of Tsukuba to the map
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (f7915f0) to head (a33a6ca).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          61       61           
  Lines        2750     2750           
=======================================
  Hits         2738     2738           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iamryo thanks for updating this map!

This is good although you need to switch latitude and longitude (this is just a convention in geojson).

I suggested a change below, you just have to click "Submit suggestion" and it will push the change.

Also, have you tried compiling the documentation locally?

docs/source/map.json Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin changed the title Update map.json Add University of Tsukuba on the user map Aug 1, 2024
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay it now shows up correctly! 🎉

Thanks for this contribution 🚀

image

@RemDelaporteMathurin RemDelaporteMathurin merged commit 4cedf6c into festim-dev:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants