Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Simulation.exports setter #836

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fixed Simulation.exports setter #836

merged 4 commits into from
Jul 31, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Fixes #833

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Jul 31, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the 1.3.1 milestone Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (31864c8) to head (d34a463).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   99.55%   99.58%   +0.02%     
==========================================
  Files          61       61              
  Lines        2724     2874     +150     
==========================================
+ Hits         2712     2862     +150     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin
Copy link
Collaborator Author

@KulaginVladimir would you mind giving this a quick look? I think this is a result of these classes now inheriting from list

Copy link
Collaborator

@KulaginVladimir KulaginVladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix should work 👌🏻

Unfortunately, I can't check it thoroughly at the moment. As I understand, the problem was only with derived quantities, right?

festim/generic_simulation.py Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin merged commit 282071e into main Jul 31, 2024
8 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix-833 branch August 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Simulation.exports should always be a list
2 participants