Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ornl #809

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add ornl #809

merged 3 commits into from
Jul 11, 2024

Conversation

jbae11
Copy link
Contributor

@jbae11 jbae11 commented Jul 11, 2024

Proposed changes

Adding ORNL to the map of FESTIM users!

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jbae11
Copy link
Contributor Author

jbae11 commented Jul 11, 2024

please squash the commits when merging, I was trying to figure out geojson :)

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jbae11 thanks for this contribution!!! We are thrilled to know that FESTIM is used at Oak Ridge! 🎉

Don't hesitate to join the Slack channel or hang out on the Discourse forum if you need support from the FESTIM community!

We also hold monthly FESTIM community meetings open to everyone, the next one is Thursday 25th at 3 PM here's the zoom link.

I can send you an invite via email too

@RemDelaporteMathurin RemDelaporteMathurin merged commit a2fd832 into festim-dev:main Jul 11, 2024
4 checks passed
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (02f79ad) to head (b5a59b3).
Report is 114 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          61       61           
  Lines        2705     2705           
=======================================
  Hits         2693     2693           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants