-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update time dependent bcs #619
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #619 +/- ##
===========================================
- Coverage 98.46% 97.96% -0.50%
===========================================
Files 18 18
Lines 715 738 +23
===========================================
+ Hits 704 723 +19
- Misses 11 15 +4
☔ View full report in Codecov by Sentry. |
I see one major caveat is that as soon as we have time dependent temperature, this will be broken. We expect to have time dependent temperature soon, so I would hold onto this PR for now and wait until we have it implemented and then we can come back to it to have a more complete implementation. |
Let's wait until #620 is merged before looking at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I know it's hard to test that the bc is updated only once.
Although we could potentially do it by timing the operation, but maybe a manual test is enough for now.
Have you tested it manually by having print statements?
Yep, I'll merge it then |
Proposed changes
Currently, all boundary conditions are updated at each time step to ensure the value is updated in case it's dependent on time. With this change, only boundary conditions with values dependent on time will be updated at each time step. This should also improve performance.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...