Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new docker workflow #595

Merged
merged 22 commits into from
Oct 11, 2023
Merged

new docker workflow #595

merged 22 commits into from
Oct 11, 2023

Conversation

jhdark
Copy link
Collaborator

@jhdark jhdark commented Oct 11, 2023

Proposed changes

new docker ci workflow to run in PRs and push.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (39060c6) 89.23% compared to head (340299f) 89.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #595   +/-   ##
========================================
  Coverage    89.23%   89.23%           
========================================
  Files            5        5           
  Lines          130      130           
========================================
  Hits           116      116           
  Misses          14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhdark jhdark marked this pull request as ready for review October 11, 2023 16:49
@jhdark jhdark merged commit c95993e into festim-dev:fenicsx Oct 11, 2023
5 checks passed
@jhdark jhdark deleted the docker_ci_workflow branch October 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant